fix the CI by adding a resolution for the broken release of enhanced resolve, and also overriding the dep version of types/node on sandboxes so that they may be linked #19936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resolve, and also overriding the dep version of types/node on sandboxes so that they may be linked
ndelangen
requested review from
gaetanmaisse,
yannbf,
kasperpeulen and
a team
JReinhold
approved these changes
Nov 23, 2022
valentinpalkovic
approved these changes
Nov 23, 2022
|
@ndelangen can we revert this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: the CI is currently failing, this should resolve that until webpack/enhanced-resolve#362 is fixed upstream
What I did
I added a yarn resolution to the script that generates the sandboxes.
This forces the use of a version of
enhanced-resolvethat we know works.I added a install of
@types/nodeversion 16, that overrides the version of the generator, the ensure we can link the sanbox to storybook code via portals.